Fix callable type mapping to be Closure mapping#753
Merged
oojacoboo merged 2 commits intothecodingmachine:masterfrom Aug 1, 2025
Merged
Fix callable type mapping to be Closure mapping#753oojacoboo merged 2 commits intothecodingmachine:masterfrom
oojacoboo merged 2 commits intothecodingmachine:masterfrom
Conversation
Contributor
Author
|
@oojacoboo It's likely that the issue you described in #739 was due to this. It would be hard to catch otherwise, because it's caused by specific values returned from fields |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #753 +/- ##
============================================
- Coverage 95.72% 94.83% -0.90%
- Complexity 1773 1845 +72
============================================
Files 154 175 +21
Lines 4586 5013 +427
============================================
+ Hits 4390 4754 +364
- Misses 196 259 +63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oojacoboo
approved these changes
Aug 1, 2025
Collaborator
|
This is a good safe option - thanks! And yes, this was the issue with #739 |
Contributor
Author
|
@oojacoboo Could you tag a release please? Thank you :) |
Collaborator
|
@oprypkhantc tagged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite accidentally I discovered a bug with my implementation: if a value that is also a callable is returned from a field, it will get wrapped in a
Deferredwrapper and be called as a callable, instead of simply being returned as a value.E.g.:
If you then run the
test { title }query, instead of simply returning the{"title": "test"}, it would call thetestfunction - becauseis_callable('test')returnstrue.Potential fixes
This could be solved two ways:
callable, only leave support for actualClosurecallable, but make it so it wraps values inDeferredbased on whether the type was specified as callable, not if the value itself is callableThis PR implements option #1. Option #2 would require some architectural changes to how GraphQLite works, way outside the scope of this feature :)